-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ocp_setup.sh to set common setup for OCP clusters #1032
base: master
Are you sure you want to change the base?
Conversation
😊 Welcome @fjglira! This is either your first contribution to the Istio common-files repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @fjglira. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: frherrer <frherrer@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain a bit more? The T&R stance currently is to test istio
organization exclusively on kind, so we would want to get more buy-in before making any alternative decisions.
In the meantime, since that leaves only istio-ecosystem/sail-operator
using OCP it probably would be more expedient to check this into sail-operator directly?
For some context, we forked the istio repository into our org to run tests against OCP there (because of the limitations of our OpenShift prow needing admin access to the org). We basically pull in the latest commits regularly, spin up a cluster and run the tests. So we thought that maybe contributing the necessary scripts upstream would make sense - we would be maintaining them, otherwise our CI jobs fail. And if others are interested to locally test against OCP, they could do it straight out of the istio repo. But if you think it should be located elsewhere, we can keep it in the fork for now. |
Adding
ocp_setup.sh
similar to whatkind_provisioner.sh
does. The idea is to have common setup in this file to be used later to runistio/istio
andistio-ecosystem/sail-operator
integration test over OCP clusters using the proper script on each repo.This script set the internal registry of the OCP cluster to be able to pull and push the images that are going to be tested on each PR, also create the proper RoleBindings to be able to pull those images later inside the cluster