Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not 503 on Upgrade: h2c instead remove the header and ignore. #95

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

jplevyak
Copy link

Signed-off-by: John Plevyak jplevyak@gmail.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: John Plevyak <jplevyak@gmail.com>
Copy link

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have CI in istio/envoy - I tested this with -c opt, ASan, and libc++, and all tests passed.

@duderino
Copy link

@PiotrSikora thanks for manually invoking the tests. Good call

@duderino duderino merged commit 6235660 into istio:release-1.1 Aug 23, 2019
jplevyak pushed a commit to jplevyak/envoy that referenced this pull request Sep 5, 2019
Signed-off-by: Robert Panzer <robert.panzer.pb@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants