-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: break apart the ambient getting start guide (WIP) #15168
Conversation
Skipping CI for Draft Pull Request. |
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
CC @craigbox; I started working on this - not ready for review yet, but wanted to get the draft PR in. |
The first draft is ready to review -- cc @craigbox |
working on tests |
content/en/docs/ambient/getting-started/secure-and-visualize/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/ambient/getting-started/secure-and-visualize/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/ambient/getting-started/manage-traffic/index.md
Outdated
Show resolved
Hide resolved
I've broken the testing pipeline. (#15200) At one stage this PR contained a In order to unblock this I'm going to try a commit with just the empty directory, and then one with a no-op snips.sh if needed. (On the plus side, now is a good time for someone else to learn how istio.io testing works in great depth) |
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
/test doc.test.profile-none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor nits.
content/en/docs/ambient/getting-started/secure-and-visualize/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/ambient/getting-started/secure-and-visualize/index.md
Outdated
Show resolved
Hide resolved
…ndex.md Co-authored-by: Daniel Hawton <daniel@hawton.org>
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
/test doc.test.profile-none |
/test doc.test.profile-default |
/test doc.test.profile-ambient That's new |
No tests in this profile yet @kfaseela ? |
Test was migrated in #15210 yet to be merged |
OK - I don't know the dependency order here but this PR is now being checked against the ambient test and it's failing, with no apparent error - because there are no tests using it that succeed? |
The folder for running ambient-profile is created in the other PR, so not available here and failing. But the test currently is non blocking. So u can merge this PR |
The first PR is waiting for another Istio PR, so not yet merged |
approved it and the clean-up PR. Most others i saw had merged already. Let
me know what I can do. We will need to follow with a PR removing the
otherwise empty snips folder/file which will probably require forcing
through
|
@peterj: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required
…On Sun, 2 Jun 2024 at 19:55, Istio Automation ***@***.***> wrote:
@peterj <https://github.com/peterj>: The following tests *failed*, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
doc.test.profile-ambient_istio.io d79466e
<d79466e>
link
<https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio.io/15168/doc.test.profile-ambient_istio.io/1797122071340257280>
false /test doc.test.profile-ambient
doc.test.profile-demo_istio.io d79466e
<d79466e>
link
<https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio.io/15168/doc.test.profile-demo_istio.io/1797168367237337088>
unknown /test doc.test.profile-demo
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes-sigs/prow
<https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
Reply to this email directly, view it on GitHub
<#15168 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABALHT4ZIKAFBIOVNTE23TZFLFVPAVCNFSM6AAAAABIESRBT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTG4ZTSMZQGQ>
.
You are receiving this because you were mentioned.Message ID: <istio/istio
.***@***.***>
|
/cherry-pick release-1.22 |
@craigbox: #15168 failed to apply on top of branch "release-1.22":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@craigbox: new issue created for failed cherrypick: #15332 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* break apart the ambient getting start guide Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * fix linter issues Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * add tests Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * Craig's first edits * lint fixes * Fix tests * fix tests * test for istio#15200 workaround * fix tests (thanks Faseela for helping me get them running locally!) * Fix the snip generator? * remove Wasm test because it depends on snips we're moving around * rebase go.mod properly * remove spelling * new screenshots + pr fixes Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * can't test locally so let's hope * lint fixes * make gen & fix test * fixy testy * Fix snip * fix tests as we learn more * Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md Co-authored-by: Daniel Hawton <daniel@hawton.org> * fixing the wasm tests Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Co-authored-by: Craig Box <craig.box@gmail.com> Co-authored-by: Daniel Hawton <daniel@hawton.org>
* break apart the ambient getting start guide Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * fix linter issues Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * add tests Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * Craig's first edits * lint fixes * Fix tests * fix tests * test for istio#15200 workaround * fix tests (thanks Faseela for helping me get them running locally!) * Fix the snip generator? * remove Wasm test because it depends on snips we're moving around * rebase go.mod properly * remove spelling * new screenshots + pr fixes Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * can't test locally so let's hope * lint fixes * make gen & fix test * fixy testy * Fix snip * fix tests as we learn more * Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md Co-authored-by: Daniel Hawton <daniel@hawton.org> * fixing the wasm tests Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Co-authored-by: Craig Box <craig.box@gmail.com> Co-authored-by: Daniel Hawton <daniel@hawton.org>
* docs: break apart the ambient getting start guide (WIP) (#15168) * break apart the ambient getting start guide Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * fix linter issues Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * add tests Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * Craig's first edits * lint fixes * Fix tests * fix tests * test for #15200 workaround * fix tests (thanks Faseela for helping me get them running locally!) * Fix the snip generator? * remove Wasm test because it depends on snips we're moving around * rebase go.mod properly * remove spelling * new screenshots + pr fixes Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * can't test locally so let's hope * lint fixes * make gen & fix test * fixy testy * Fix snip * fix tests as we learn more * Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md Co-authored-by: Daniel Hawton <daniel@hawton.org> * fixing the wasm tests Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Co-authored-by: Craig Box <craig.box@gmail.com> Co-authored-by: Daniel Hawton <daniel@hawton.org> * cherrypick #15227 too * move ambient tests to ambient profile (#15241) Signed-off-by: Faseela K <faseela.k@est.tech> * Manual cherry-pick the last of 15293 * Fix gencheck with release-1.22 versions of the tests * re-add setup snips to fix the tests again; there's no avoiding #15200 * Update content/en/docs/ambient/getting-started/test.sh --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Signed-off-by: Faseela K <faseela.k@est.tech> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Co-authored-by: Daniel Hawton <daniel@hawton.org> Co-authored-by: Faseela K <faseela.k@est.tech> Co-authored-by: Faseela K <k.faseela@gmail.com>
Description
[WIP] Breaking up the Ambient Getting Started section into multiple smaller sections.
Reviewers
TODOs: