Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio 0.5.1 Tracker #3179

Closed
hklai opened this issue Feb 5, 2018 · 37 comments
Closed

Istio 0.5.1 Tracker #3179

hklai opened this issue Feb 5, 2018 · 37 comments

Comments

@hklai
Copy link
Contributor

hklai commented Feb 5, 2018

Istio 0.5.0 is plagued by various bugs and we are likely going to cut a 0.5.1 to remedy the critical ones.

ATM the plan is only to cherrypick fixes into 0.5.0. Please add the PRs that must be cherrypicked into 0.5.0 in this issue. Note that only critical bugs will be addressed in patch releases.

A fine print: due to the still changing build system, it is possible that simple cherrypicks may not work. If that is the case, we may cut 0.5.1 at head which can include all fixes, but also increase the risk of opening doors to other bugs. This is only a fall back option.

@hklai hklai added this to the Istio 0.5 milestone Feb 5, 2018
@hklai hklai self-assigned this Feb 5, 2018
@linsun
Copy link
Member

linsun commented Feb 5, 2018

#2965

#3008
#3010

#3175

@Stono
Copy link
Contributor

Stono commented Feb 5, 2018

Hey, sorry to be a pain in the arse but I don't see how #3099 doesn't fall into this list? Mixer is completely broken

@Stono
Copy link
Contributor

Stono commented Feb 5, 2018

Ah, you're referring to fixes already in place for an immediate cut. Sorry, i'm just at a lose end with a broken deployment.

@linsun
Copy link
Member

linsun commented Feb 5, 2018

another one: #3187

@hklai
Copy link
Contributor Author

hklai commented Feb 5, 2018

@Stono yes if you a think a fix is important enough to be included in 0.5.1, please add the PR here.

@Stono
Copy link
Contributor

Stono commented Feb 5, 2018

#3150

@hklai
Copy link
Contributor Author

hklai commented Feb 5, 2018

checked with @smawson. Cutting 0.5.1 at master/head is not an option. Only the PRs that can be merged back to the 0.5.0 branch will be included in 0.5.0.

We will carefully inspect the PRs added to this list to ensure their feasibility, and severity.

@rkpagadala
Copy link
Contributor

#3183 is needed on top of #3150

@nmnellis
Copy link
Contributor

nmnellis commented Feb 6, 2018

Low impact: #3101

@alexkoturanov
Copy link

Restore Ingress metrics: #3142

@nmnellis
Copy link
Contributor

nmnellis commented Feb 7, 2018

Ingress controller not respecting route rules: #3218

@bobbytables
Copy link
Contributor

^ Please.

@myidpt
Copy link
Contributor

myidpt commented Feb 7, 2018

K8s workload cert rotation fix: #3155 (Sorry, I committed it to V0.5.1 branch, you can revert it if this doesn't meet the requirements) Fix already in 0.5 pull request #3242

@sureshvis
Copy link

sureshvis commented Feb 7, 2018

Please include - Expose concurrency flag of envoy #3065

@jeffmendoza
Copy link
Contributor

Servicegraph is broken: #3079

@douglas-reid
Copy link
Contributor

I can't recall if #2901 was in 0.5.0, but I'd like to see it included in 0.5.1.

@ldemailly
Copy link
Member

ldemailly commented Feb 7, 2018

As it is feb 7th already we should consider making an early 0.6.0 ? (which would be ~Feb 15 anyway so 6 more days from Feb 9)

On the other hand, exercising and demonstrating our ability to make a patch release is useful

ps: can we call the release branch release-0.5 (like we did for release-0.1 and release-0.2) instead of 0.5.1 ? if we make a 0.5.2 it will likely be on that same branch, the patchlevel varies
(likewise this isn't critical for this but for LTS releases we need a long term multi patch protected branch)

@hklai
Copy link
Contributor Author

hklai commented Feb 8, 2018 via email

@rkpagadala
Copy link
Contributor

@nmnellis I am inclined to not pick up #3101 It is release critical? Why?

@costinm
Copy link
Contributor

costinm commented Feb 8, 2018

#2942

@GregHanson
Copy link
Member

#3283
#2970

@nmnellis
Copy link
Contributor

nmnellis commented Feb 8, 2018

@rkpagadala #3101 can be ignored if you choose, its just that users who deploy 0.5.0 will have to recreate that crd

@rkpagadala
Copy link
Contributor

#3078 * Update proxy SHA to almost latest.

@rlguarino
Copy link

What's the target release date for 0.5.1?

@hklai
Copy link
Contributor Author

hklai commented Feb 9, 2018 via email

@rlguarino
Copy link

Just to confirm that's Monday the 12th?

@hklai
Copy link
Contributor Author

hklai commented Feb 9, 2018 via email

@cmluciano
Copy link
Member

docs for minikube setup istio/istio.io#921

@ldemailly
Copy link
Member

0.5.1:
mixer's statsd-to-prometheus:
Image: prom/statsd-exporter:v0.5.0

@rkpagadala
Copy link
Contributor

@ldemailly The tags for statsd exporter come from prometheus official docker releases and unrelated to our 0.5.1 version.

https://hub.docker.com/r/prom/statsd-exporter/tags/

@ldemailly
Copy link
Member

oh nice coincidence, thanks @rkpagadala - @douglas-reid do you know why we are using the version from 3 months ago vs 1 month ago (0.6.0)

@rlguarino
Copy link

It this still happening today?

@hklai
Copy link
Contributor Author

hklai commented Feb 13, 2018

@rkpagadala is in the process of cutting 0.5.1. right now. Will update this bug when the release artifacts become available.

@douglas-reid
Copy link
Contributor

@ldemailly because we added it ~3 months ago and have not since updated.

@hklai
Copy link
Contributor Author

hklai commented Feb 13, 2018

@hklai hklai closed this as completed Feb 13, 2018
@bobbytables
Copy link
Contributor

Thanks for all of the work on this Istio team. 🍻 We have 0.5.1 in our integration cluster now and we're seeing a few of the bugs we saw go away. Namely, the wildcard routing one is resolved.

@ayj
Copy link
Contributor

ayj commented Feb 13, 2018

FYI - I forgot to include #3036 in the 0.5.1 release cherry-pick list. I've updated the setup instructions to refer uses to download the missing scripts directly from github (see istio/istio.io#983)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests