Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement operator e2e #1933

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Implement operator e2e #1933

merged 2 commits into from
Oct 17, 2019

Conversation

sdake
Copy link
Member

@sdake sdake commented Oct 14, 2019

Depends-On: istio/operator#379

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 14, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2019
@sdake sdake requested a review from howardjohn October 16, 2019 20:17
@@ -24,6 +24,11 @@ jobs:
command: [make, gen-check]
modifiers: [optional]

- name: e2e
command: [entryppoint, make, e2e]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@sdake
Copy link
Member Author

sdake commented Oct 17, 2019

@howardjohn can you PTAL?

TX
-steve

command: [entrypoint, make, e2e]
requirements: [kind]
modifiers: [optional]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repos: [istio/istio]

to automatically checkout istio. Can be a followup

@istio-testing istio-testing merged commit 242a3d6 into istio:master Oct 17, 2019
@istio-testing
Copy link
Collaborator

@sdake: Updated the job-config configmap in namespace default using the following files:

  • key istio.operator.master.gen.yaml using file prow/cluster/jobs/istio/operator/istio.operator.master.gen.yaml

In response to this:

Depends-On: istio/operator#379

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 1, 2019
* Implement operator e2e

Depends-On: istio/operator#379

* Address reviewer comments
sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 1, 2019
* Implement operator e2e

Depends-On: istio/operator#379

* Address reviewer comments
sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 1, 2019
* Implement operator e2e

Depends-On: istio/operator#379

* Address reviewer comments
sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 5, 2019
* Implement operator e2e

Depends-On: istio/operator#379

* Address reviewer comments
sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 5, 2019
* Implement operator e2e

Depends-On: istio/operator#379

* Address reviewer comments
sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 5, 2019
* Implement operator e2e

Depends-On: istio/operator#379

* Address reviewer comments
sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 17, 2019
* Implement operator e2e

Depends-On: istio/operator#379

* Address reviewer comments
sdake pushed a commit to sdake/test-infra that referenced this pull request Dec 18, 2019
* Implement operator e2e

Depends-On: istio/operator#379

* Address reviewer comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants