Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup heap profiling support #19

Closed
howardjohn opened this issue Oct 19, 2022 · 6 comments
Closed

Setup heap profiling support #19

howardjohn opened this issue Oct 19, 2022 · 6 comments
Labels
area/debuggability Area: Debuggability (logs, utils, admin endpoints, etc) area/performance Area: Performance P1

Comments

@howardjohn
Copy link
Member

And make sure existing CPU profiling still works

@stevenctl
Copy link
Contributor

Is this working? I see there's a gprof/heap endpoint now

@howardjohn
Copy link
Member Author

howardjohn commented Oct 31, 2022

Basically you can swap out heap allocators, and each one has their own profiling methods. gprof in particular was very hard to compile. I think it could be statically linked but I couldn't figure out how. And may have implications beyond profiling

This was referenced Nov 9, 2022
@stevenctl stevenctl added this to the M1: Performance milestone Nov 9, 2022
@hzxuzhonghu
Copy link
Member

/assign

@hzxuzhonghu
Copy link
Member

gperftools https://github.com/dignifiedquire/rust-gperftools has not been active for 4 years. Do we still want to use it?

@howardjohn
Copy link
Member Author

Aside from 4 years old it also doesn't statically link so I think its probably problematic

@howardjohn
Copy link
Member Author

tracking more in #863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/debuggability Area: Debuggability (logs, utils, admin endpoints, etc) area/performance Area: Performance P1
Projects
Status: Done
Development

No branches or pull requests

3 participants