-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance ztunnel heap instrumentation #863
Comments
https://github.com/polarsignals/rust-jemalloc-pprof or https://github.com/mkmik/heappy/ seem viable. Prototype with heappy: https://github.com/howardjohn/ztunnel/pull/new/exp/heappy |
Yep, using https://github.com/polarsignals/rust-jemalloc-pprof, seems to work well enough. |
should #865 close this one out? |
bleggett
changed the title
Support heap dumps / fix gperftools
Enhance ztunnel heap instrumentation
Apr 3, 2024
seems the second task has be completed, maybe we can close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now
ztunnel
exposes gperftools endpoints for both profiles and heaps, as well as a standardpprof
profile.ATM the
gperftools
endpoints don't work very well, or at all.We should probably consolidate on 1 profiler and one heap dumper, and make sure they both work - whether that's
gperftools
or something else (jemalloc
was mentioned).Whatever we DO pick needs to work equally well on arm64 and amd64, and needs to support remote analysis, ideally.
jemalloc
by default, at least for non-release builds, possibly for release builds if it is not a perf hit (e.g. at one time Facebook leftjemalloc
on permanently in prod due to nonexistent perf hit: https://www.magiroux.com/rust-jemalloc-profiling/)The text was updated successfully, but these errors were encountered: