Remove gperftools, use jemalloc #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/L
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
force-pushed
the
bleggett/fix-heapdump
branch
from
af16112
to
10d19a6
Compare
howardjohn
approved these changes
Apr 2, 2024
| @@ -6,7 +6,7 @@ rust-version = "1.65" | |||
|
|
|||
| [features] | |||
| default = ["tls-ring"] | |||
| gperftools = ["dep:gperftools"] | |||
| jemalloc = ["dep:tikv-jemallocator", "dep:jemalloc_pprof"] | |||
There was a problem hiding this comment.
should we default to jemalloc? and/or unconditionally use it? or do we think we need more performance testing?
There was a problem hiding this comment.
For now I would rather not, this is just a drop-in replacement for what we had before that works, but we can certainly look into doing that later, yeah.
I think the impact will be minimal tho, I just haven't tried it myself.
src/admin.rs
Outdated
| async fn handle_jemalloc_pprof_heapgen(_req: Request<Incoming>) -> Response<Full<Bytes>> { | ||
| const FILE_PATH: &str = "/tmp/jemalloc-pprof-heap.prof"; | ||
| // make sure the file exists/is writable before handing to gprof | ||
| File::create(FILE_PATH).await.unwrap(); |
There was a problem hiding this comment.
can we stream it back instead of file? is the format the "pprof" format that can be read by go tool pprof or some other format?
There was a problem hiding this comment.
go tool pprof - starting a PROFILING.md
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to actually work, requires no container deps, keeping as an optional build target for now.
Signed-off-by: Benjamin Leggett benjamin.leggett@solo.io