-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DNS in on-demand XDS #577
Comments
nmittler
added a commit
to nmittler/ztunnel
that referenced
this issue
Jun 28, 2023
The DNS proxy does not currently support on-demand mode (see istio#577). For now, just explicitly fail at startup if the user tried enabling both options.
nmittler
added a commit
to nmittler/ztunnel
that referenced
this issue
Jun 28, 2023
The DNS proxy does not currently support on-demand mode (see istio#577). For now, just explicitly fail at startup if the user tried enabling both options.
istio-testing
pushed a commit
that referenced
this issue
Jun 28, 2023
The DNS proxy does not currently support on-demand mode (see #577). For now, just explicitly fail at startup if the user tried enabling both options.
Discussed with @howardjohn offline. There is some concern regarding the needs of DNS WRT the current on-demand XDS API. Specifically:
Need further discussion to find a path forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current DNS proxy does not support on-demand mode. This is because it simply assumes that all the workloads and services it needs are already in the
ProxyState
.Since DNS requests are the first thing done when making a request, the
ProxyState
would be empty (except for local workloads). This means that the DNS proxy will have to perform the on-demand handshake. However, the requirements for DNS on-demand differ slightly from what we have today:mysvc.myns
is queried, the DNS proxy will lookup all of the following until it finds a matching service:mysvc.myns
,mysvc.myns.svc
,mysvc.myns.svc.cluster.local
.I believe with these 2 things in place, the new flow for the DNS proxy could be something like:
ProxyState
. If found, done.ProxyState
. If found, done.The text was updated successfully, but these errors were encountered: