Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPP options with ‘-‘ in the name ignored, when passed to ipptransform #282

Closed
AFischer4 opened this issue Jun 12, 2023 · 1 comment
Closed
Assignees
Milestone

Comments

@AFischer4
Copy link

Calling ipptool -v -T 3 ipp://<IPPHost>:8000/ipp/print/<MyPrinter> -f <sample>.pdf ex-print-job.test
fails to propagate IPP options with ‘-‘ in the name to ipptransform.

For example ATTR enum print-quality 5 in ex-print-job.test will be passed to ipptransform as environment variable IPP_PRINT_QUALITY=high but the function get_option() in ipptransform does not find the option, because it is looking first for a non existing command line option “print-quality” then for an environment variable “IPP_PRINT-QUALITY” and then for “IPP_PRINT-QUALITY_DEFAULT”.

The algorithm in get_option() to build the name of the environment variable must be the same, as in serverTransformJob().
At the moment the replacement of ‘-‘ to ‘_’ is missing in get_options()!

Without correction, ipptransform will ignore a lot of options set by environment variables, because the initialization in ippOptionsNew() / get_option() is looking for the wrong names.
i
Screenshots
If applicable, add screenshots to help explain your problem.

I used ippsample "v2023.03" for the tests.

@AFischer4 AFischer4 changed the title IPP options with ‘-‘ in the name Ignored, when passed to ipptransform do not work as expected IPP options with ‘-‘ in the name ignored, when passed to ipptransform Jun 12, 2023
@michaelrsweet michaelrsweet self-assigned this Jun 19, 2023
@michaelrsweet michaelrsweet added this to the Stable milestone Jun 19, 2023
@michaelrsweet
Copy link
Contributor

[master e895c10] Fix handling of attributes with dashes in the name (Issue #282)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants