Mpdz2 649 e mail notification #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at-m/zammad-ldap-sync into MPDZ2-649_EMail_Notification
markostreich
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Die Testabdeckung hat sich wesentlich verbessert, was sehr gut ist. Bei den Tests würde ich jeweils noch ein, zwei Hinweise zum Testziel hinzufügen, weil es durch die Verwendung des ArgumentCaptor etwas schwer verständlich ist. Das so gemockt werden muss, sehe ich aber auch.
Die anderen Kleinigkeiten sollten noch ausgebessert werden.
src/test/java/de/muenchen/zammad/ldap/service/CreateUpdateGroupAndUserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/de/muenchen/zammad/ldap/service/DeleteGroupAndUserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/de/muenchen/zammad/ldap/service/DistinguishedNameEMailTest.java
Outdated
Show resolved
Hide resolved
src/test/java/de/muenchen/zammad/ldap/service/PrepareTestEnvironment.java
Outdated
Show resolved
Hide resolved
src/test/java/de/muenchen/zammad/ldap/service/PrepareTestEnvironment.java
Outdated
Show resolved
Hide resolved
markostreich
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference
Issues