An handled exception causes crash #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the handling of exception that could cause crash This could happen when the authorization URL is not valid (it depends on how it is set from outside) ### how to reproduce - force the authorization URI to this invalid URI (`setUrl(url)`) ``` https://idserver.servizicie.interno.gov.it/OpenApp?nextUrl=https://idserver.servizicie.interno.gov.it/idp/Authn/X509&name=conversation&value=e1s2&authnRequestString=_ec725700fad278600a2a&OpText=Inserisci le ultime 4 cifre del PIN ricevute insieme alla tua Carta di Identità Elettronica per accedere a https://app-backend.io.italia.it&imgUrl=https://idserver.servizicie.interno.gov.it/idpimages/cielogo.pngshould ``` - set the PIN of your CIE card - read your NFC card - 💥 ⛑️ special thanks to @fabriziofff to find this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the handling of exception that could cause crash
This could happen when the authorization URL is not valid (it depends on how it is set from outside)
the unhandled exception
more details https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#error-handling
how to reproduce
setUrl(url))⛑️ special thanks to @fabriziofff to find this issue
pagopa/io-cie-sdk#37