Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

̶f̶i̶x̶:̶ ̶r̶e̶m̶o̶v̶e̶ ̶̶d̶o̶c̶k̶e̶r̶-̶e̶x̶a̶m̶p̶l̶e̶̶ ̶f̶o̶l̶d̶e̶r̶ ̶u̶s̶a̶g̶e̶ ̶ docs: specify example folder is not production ready #118

Conversation

salvatorelaiso
Copy link
Collaborator

Remove docker-example and use example.

Modified references in CI and documentation.

Closes #116

peppelinux and others added 30 commits July 21, 2023 12:01
* python version selected dinamically for docker version

* fixed python version

* added enviroments description

* fix enviroment's name and echo

* fir doker-compose and readme files

* fix: change library from libressl-dev to openssl-dev

* Update target_based_routing.yaml

Fixed ficep entity_id name

* New ficep metadata

* chore: added dependency for django theme

* Fix: remove of non existing field of user

* feat: implemented Django template for the example sp

* chore: example project - disco, proxy_conf and README

* chore: README

* chore: README added CORSO IDEM Proxy

* fix: Docker compose

* fix: Docker compose - README

* fix: Docker compose - README

* pyff folder renamed

* Docker revamp

* Docker revamp

* chore: created static folder with static files

* fix: adding missing STATIC_ROOT

* fix: using {% static %} for static resources

* fix: removed unused code

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Docker revamp

* fix: Docker entrypoint

* chore: README

* chore: README

* fix: docker compose

---------

Co-authored-by: Alessio Murru <alessio.murru@it.ey.com>
Co-authored-by: MDreW <andrea.ranaldi@gmail.com>
Co-authored-by: Gartic99 <artic.1804049@studenti.uniroma1.it>
Co-authored-by: Ghenadie Artic <57416779+Gartic99@users.noreply.github.com>
* chore: added dependency for django theme

* Fix: remove of non existing field of user

* feat: implemented Django template for the example sp

* chore: created static folder with static files

* fix: adding missing STATIC_ROOT

* fix: using {% static %} for static resources

* fix: removed unused code

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* feat: dropdown for profile

* fix: resolved merge conflicts

---------

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
* new discovery and error page based on bootstrap-itali v2.6.1

* added id and class for errors

* chore: added dependency for django theme

* Fix: remove of non existing field of user

* feat: implemented Django template for the example sp

* chore: created static folder with static files

* fix: adding missing STATIC_ROOT

* fix: using {% static %} for static resources

* fix: removed unused code

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* Update example_sp/djangosaml2_sp/saml2_sp/views.py

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

* feat: dropdown for profile

* fix: resolved merge conflicts

* chore: removed comments on disco.html file

* feat: improved echo_attributes page

* Update Docker-compose/docker-compose.yml

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>

---------

Co-authored-by: MDreW <andrea.ranaldi@gmail.com>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
…nment (italia#95)

* Modifica Readme Satosa-Saml2Spid

* aggiornamento django Readme

* aggiornamento  Readme

* Update readme - second release

* update - review readme

* create new Readme about DEMO SAML2 SP + remove blanck lines + modified django readme

* Apply suggestions from code review

---------

Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
salvatorelaiso and others added 6 commits January 22, 2024 15:02
* fix: remove `apply_conf.sh` script and use ENV vars instead

* fix: remove `apply_conf.sh` script and use ENV vars instead

* fix: delete `apply_conf.sh` file

* fix: separate `SATOSA_BASE_STATIC` from `SATOSA_BASE`

---------

Co-authored-by: Salvatore Laiso <salvatore.laiso@it.ey.com>
…doc (italia#104)

* Update CI workflow + ADD django_sp in Docker-compose

* Update CI Workflow - Review 2

* Update CI Workflow - Review 2.1

* Update CI Workflow - Review 2.2

* Update CI workflow + Docker-compose (review 3.1)

* issue italia#92 - add pyeudiw documentation ref

* issue italia#92 - add pyeudiw documentation ref (review)

* issue italia#92 - add pyeudiw documentation ref (review2)
* fix: align pyeudiw yaml config file

* fix: align disco page to pyeudiw

* fix: align base html to pyeudiw

* fix: align qrcode to pyeudiw

* fix: change reference to correct bootstrap

* fix: add statics needed by spid_base

* doc: update Configuration by environment variables section
* fix: github action

* fix: temporary retrieve `pyeudiw` from github repo

* fix: add `eudi` branch into CI triggers

* chore: linting and container status info

* fix: missing dependencies in CI host machine

* fix: wait container startup

* fix: add healthcheck

---------

Co-authored-by: Salvatore Laiso <salvatore.laiso@it.ey.com>
Remove `docker-example` and use `example`.
@salvatorelaiso salvatorelaiso marked this pull request as draft February 1, 2024 14:43
@salvatorelaiso salvatorelaiso marked this pull request as ready for review February 1, 2024 14:44
@salvatorelaiso salvatorelaiso marked this pull request as draft February 5, 2024 10:43
@salvatorelaiso
Copy link
Collaborator Author

49b9a76 resolves #115

@salvatorelaiso
Copy link
Collaborator Author

salvatorelaiso commented Feb 5, 2024

This PR no longer satisfies #116 which is an unintended development.

Adds a warning in Docker-compose/README.md which states the danger of using example in a production environment.

@salvatorelaiso salvatorelaiso marked this pull request as ready for review February 5, 2024 11:42
@salvatorelaiso salvatorelaiso changed the title fix: remove docker-example folder usage ~~fix: remove docker-example folder usage~~ docs: specify example folder is not production ready Feb 5, 2024
@salvatorelaiso salvatorelaiso changed the title ~~fix: remove docker-example folder usage~~ docs: specify example folder is not production ready f̶i̶x̶:̶ ̶r̶e̶m̶o̶v̶e̶ ̶̶d̶o̶c̶k̶e̶r̶-̶e̶x̶a̶m̶p̶l̶e̶̶ ̶f̶o̶l̶d̶e̶r̶ ̶u̶s̶a̶g̶e̶ docs: specify example folder is not production ready Feb 5, 2024
@salvatorelaiso salvatorelaiso changed the title f̶i̶x̶:̶ ̶r̶e̶m̶o̶v̶e̶ ̶̶d̶o̶c̶k̶e̶r̶-̶e̶x̶a̶m̶p̶l̶e̶̶ ̶f̶o̶l̶d̶e̶r̶ ̶u̶s̶a̶g̶e̶ docs: specify example folder is not production ready f̶i̶x̶:̶ ̶r̶e̶m̶o̶v̶e̶ ̶̶d̶o̶c̶k̶e̶r̶-̶e̶x̶a̶m̶p̶l̶e̶̶ ̶f̶o̶l̶d̶e̶r̶ ̶u̶s̶a̶g̶e̶ docs: specify example folder is not production ready Feb 5, 2024
@salvatorelaiso salvatorelaiso changed the title f̶i̶x̶:̶ ̶r̶e̶m̶o̶v̶e̶ ̶̶d̶o̶c̶k̶e̶r̶-̶e̶x̶a̶m̶p̶l̶e̶̶ ̶f̶o̶l̶d̶e̶r̶ ̶u̶s̶a̶g̶e̶ docs: specify example folder is not production ready ̶f̶i̶x̶:̶ ̶r̶e̶m̶o̶v̶e̶ ̶̶d̶o̶c̶k̶e̶r̶-̶e̶x̶a̶m̶p̶l̶e̶̶ ̶f̶o̶l̶d̶e̶r̶ ̶u̶s̶a̶g̶e̶ ̶ docs: specify example folder is not production ready Feb 5, 2024
@peppelinux peppelinux changed the base branch from eudi to master February 6, 2024 22:32
@peppelinux peppelinux changed the base branch from master to eudi February 6, 2024 22:34
@peppelinux peppelinux changed the base branch from eudi to master February 6, 2024 22:34
@peppelinux
Copy link
Member

@salvatorelaiso avevi parto la PR sul branch eudi, l'ho ripuntaot su master

vedo che ci sono conflitti?
Puoi fare una valutazione di quanti commti sono andati su eudi delle precedenti PR e allineare master? Altrimenti ci perdiamo le PR su un branch morto

@salvatorelaiso salvatorelaiso changed the base branch from master to eudi February 7, 2024 08:35
@salvatorelaiso salvatorelaiso changed the base branch from eudi to master February 7, 2024 08:35
@salvatorelaiso
Copy link
Collaborator Author

Closing in favor of #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-example directory
4 participants