-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local mount, profiles and new docs #152
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
3369235 | Triggered | Generic High Entropy Secret | 3c4c1d6 | Docker-compose/mongo/db/.mongodb/mongosh/66c8648753e2f14983a26a12_log | View secret |
3369235 | Triggered | Generic High Entropy Secret | 3c4c1d6 | Docker-compose/mongo/db/.mongodb/mongosh/66c8776831e5574dd75e739b_log | View secret |
3369235 | Triggered | Generic High Entropy Secret | 6c693af | Docker-compose/mongo/db/.mongodb/mongosh/66c8648753e2f14983a26a12_log | View secret |
3369235 | Triggered | Generic High Entropy Secret | 6c693af | Docker-compose/mongo/db/.mongodb/mongosh/66c8776831e5574dd75e739b_log | View secret |
5632966 | Triggered | Username Password | 87c7f90 | Docker-compose/docker-compose.yml | View secret |
5632967 | Triggered | Generic High Entropy Secret | 3c4c1d6 | Docker-compose/mongo/db/.mongodb/mongosh/66c8776831e5574dd75e739b_log | View secret |
5632967 | Triggered | Generic High Entropy Secret | 3c4c1d6 | Docker-compose/mongo/db/.mongodb/mongosh/66c8648753e2f14983a26a12_log | View secret |
5632967 | Triggered | Generic High Entropy Secret | 6c693af | Docker-compose/mongo/db/.mongodb/mongosh/66c8776831e5574dd75e739b_log | View secret |
5632967 | Triggered | Generic High Entropy Secret | 6c693af | Docker-compose/mongo/db/.mongodb/mongosh/66c8648753e2f14983a26a12_log | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Docker-compose/docker-compose.yml
Outdated
@@ -110,8 +108,7 @@ services: | |||
ports: | |||
- "10000:10000" | |||
volumes: | |||
- /usr/share/zoneinfo/Europe/Rome:/etc/localtime:ro | |||
- ../docker-example:/satosa_proxy:rw | |||
- ./satosa:/satosa_proxy:rw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
satosa -> project?
I agree that docker-example
is too much related to the demo purposes, while satosa is too much generic and might confuse the software/application name with the local configuration, I suppose that project
or any other similar alternative might better explain the purpose of that folder
Added TZ in docker compose, update satosa Dockerfile to support this. [ranaldi@andrea-ranaldi-p Satosa-Saml2Spid]$ docker run -tie TZ=Europe/Berlin satosa bash
126b80233e9b:/satosa_proxy# date
Wed Aug 28 17:05:22 CEST 2024
[ranaldi@andrea-ranaldi-p Satosa-Saml2Spid]$ docker run -tie TZ=Australia/Melbourne satosa bash
7c1efed81ada:/satosa_proxy# date
Thu Aug 29 01:05:39 AEST 2024 |
I have added profiles demo to start all services and dataentry for add mongo-express service. I have update update
At last I have update @Zicchio you can try this on windows? |
ports: | ||
- 8082:8081 | ||
depends_on: | ||
- satosa-mongo | ||
environment: | ||
ME_CONFIG_BASICAUTH_USERNAME: satosauser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldnt be mettere to have them in ENV?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For instances with only spid-saml backend? I can try 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @peppelinux ,
I have tried and I can't use an Environment to enable mongo dependence on compose because depends_on
don't accept "null" as value:
service "satosa-saml2spid" depends on undefined service "": invalid
I can propose a new docker compose profile for MongoDB? The profiles can be:
default (without profile):
- satosa-sa,l2spid (without mongo dependancy)
- satosa-nginx
db:
- *default
- satosa-mongo
dataentry:
- *default
- *db
- satosa-mongoexpress
dev:
- *default
- django-sp
- spid-samlcheck
demo:
- default*
- *db
- *dataentry
- *dev
If I use an external MongoDB, is sufficient don't start the db
profile (only default) or use dev
profile for a full system without mongo.
What do you think?
Docker-compose/docker-compose.yml
Outdated
@@ -110,8 +113,8 @@ services: | |||
ports: | |||
- "10000:10000" | |||
volumes: | |||
- /usr/share/zoneinfo/Europe/Rome:/etc/localtime:ro | |||
- ../docker-example:/satosa_proxy:rw | |||
- ./satosa:/satosa_proxy:rw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ./satosa:/satosa_proxy:rw | |
- ./satosa-project:/satosa_proxy:rw |
Migrate to #160 |
This is an example for a docker compose without static volumes, has only example scope
-f
option for clean old dp/application data and reinitialize the sistem-h
option for print help