Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed action #60

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Fixed action #60

merged 3 commits into from
Nov 22, 2022

Conversation

MdreW
Copy link
Collaborator

@MdreW MdreW commented Nov 19, 2022

No description provided.

@MdreW MdreW requested a review from peppelinux November 19, 2022 14:04
@peppelinux
Copy link
Member

Ok, the certificate Is expired and the ci failed. We have to create new one with spid-compliant-certificates and substitite the oldones

Todo.

@MdreW
Copy link
Collaborator Author

MdreW commented Nov 19, 2022

I have update with a new certificate (3650 days of value) but now we have a ficep error.
P.S. @peppelinux you have updated spid-sp-test?

@peppelinux
Copy link
Member

I have update with a new certificate (3650 days of value) but now we have a ficep error. P.S. @peppelinux you have updated spid-sp-test?

That's the point, spid-sp-test needs new certificates. I wonder why we had such a expired cert in a so short period ...

@peppelinux
Copy link
Member

Updated
https://github.com/italia/spid-sp-test/releases/tag/v1.2.8

but CI still fails for other reasons @MdreW

@@ -65,3 +66,5 @@ jobs:
cd example
spid_sp_test --idp-metadata > metadata/idp/spid-sp-test.xml
spid_sp_test --metadata-url https://localhost:10000/spidSaml2/metadata --authn-url "http://localhost:8000/saml2/login/?idp=https://localhost:10000/Saml2IDP/metadata&next=/saml2/echo_attributes&idphint=https%253A%252F%252Flocalhost%253A8080" -ap spid_sp_test.plugins.authn_request.SatosaSaml2Spid --extra --debug ERROR -tr
spid_sp_test --profile cie-sp-public --metadata-url https://localhost:10000/cieSaml2/metadata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consiglio di non appendere i tests ma di creare sezioni con identificativi separati, tipo

    - name: spid-sp-test CIE id
      run: |
        cd example
        spid_sp_test --profile cie-sp-public --metadata-url https://localhost:10000/cieSaml2/metadata

@peppelinux peppelinux merged commit 03e8e52 into master Nov 22, 2022
@MdreW MdreW deleted the MdreW-patch-1 branch October 7, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants