Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflow to build and push Docker image #16

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Fix workflow to build and push Docker image #16

merged 3 commits into from
Apr 19, 2021

Conversation

psmiraglia
Copy link
Member

@psmiraglia psmiraglia commented Apr 13, 2021 •
edited
Loading

Scope of the pull request

The PR fixes the docker workflow. It introduces also the need of defining a new secret named DOCKER_BASE_REPO.

Solved issues

Added issues

None

Tests

  • I manually tested it
  • I added unit test
  • I ran the existing unit test and they do not fail

@psmiraglia psmiraglia added this to the 0.1 milestone Apr 13, 2021
@psmiraglia psmiraglia added the bug Something isn't working label Apr 13, 2021
@psmiraglia psmiraglia marked this pull request as ready for review April 13, 2021 13:38
@psmiraglia psmiraglia force-pushed the fix/docker-workflow branch from 0622f7b to d419c7b Compare April 13, 2021 13:43
@psmiraglia psmiraglia changed the title Fix/docker workflow Fix docker workflow Apr 13, 2021
@psmiraglia psmiraglia requested review from bfabio and peppelinux April 13, 2021 13:44
@psmiraglia psmiraglia added chore Maintenance task and removed bug Something isn't working labels Apr 13, 2021
@psmiraglia psmiraglia mentioned this pull request Apr 13, 2021
Closed
bfabio
bfabio suggested changes Apr 15, 2021
View reviewed changes
.github/workflows/docker.yml Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
@psmiraglia psmiraglia removed this from the 0.1 milestone Apr 19, 2021
@bfabio bfabio self-requested a review April 19, 2021 16:47
@psmiraglia psmiraglia changed the title Fix docker workflow Fix workflow to build and push Docker image Apr 19, 2021
@psmiraglia psmiraglia merged commit bfb32d1 into italia:main Apr 19, 2021
@psmiraglia psmiraglia added this to the 0.2 milestone Apr 19, 2021
@psmiraglia psmiraglia deleted the fix/docker-workflow branch April 20, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppelinux peppelinux peppelinux approved these changes

@bfabio bfabio bfabio approved these changes

Assignees
No one assigned
Labels
chore Maintenance task
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.

Wrong composition of Docker image name Wrong logical comparison in docker workflow
3 participants
@psmiraglia @bfabio @peppelinux