fix: url validation using built-in class #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#275 Va a fixare questo |
|
@damikael per favore fai il merge di questa pull request. sto tentando di testare in localhost con il plugin di keycloak e sto avendo difficoltà a causa dello stato del regex. proabilmente non è l'unico problema che ho ma vorrei averne uno in meno. ho guardato il file di utils e il cambiamento pare perfettamente ragionato. puoi anche testarlo aprendo i devtools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uso la classe URL invece del RegExp, che è errato per alcune URL (tipo dentro docker
http://web:4000/metadata, l'host non deve per forza avere il dominio).