Fixed null var reference (#24)

Fixed null var reference Fixed Session check against `Session` instance
italia · Jan 20, 2019 · e4a65d5 · e4a65d5
1 parent d60e350
commit e4a65d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/Controller/SecurityController.php b/Controller/SecurityController.php
@@ -70,7 +70,7 @@ public function loginAction(Request $request)
     public function acsAction(Request $request)
     {
         if ($this->sp->isAuthenticated()) {
-            return ['attributes' => $sp->getAttributes()];
+            return ['attributes' => $this->sp->getAttributes()];
         }
         return new Response("Unauthenticated", 401);
     }
@@ -79,4 +79,4 @@ public function singleLogoutAction(Request $request)
     {
         throw new \Exception('Uninmplemented');
     }
-}
+}
diff --git a/Security/SpidAuthenticator.php b/Security/SpidAuthenticator.php
@@ -100,10 +100,9 @@ public function supportsRememberMe()
     public function supports(Request $request): bool
     {
         if (!isset($_SESSION['spidSession']) ||
-                !($_SESSION['spidSession'] instanceof Session) ||
-                !isset($_SESSION['spidSession']->idp) ||
-                !isset($_SESSION['spidSession']->level) ||
-                !isset($_SESSION['spidSession']->attributes)
+            !isset($_SESSION['spidSession']['idp']) ||
+            !isset($_SESSION['spidSession']['level']) ||
+            !isset($_SESSION['spidSession']['attributes'])
         ) {
             return false;
         } else {