Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize inputs before using them #29

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Sanitize inputs before using them #29

merged 2 commits into from
Dec 14, 2021

Conversation

italolelis
Copy link
Owner

Fixes sanitization for log inputs. This increases security when logging information for every request.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Log inputs are not sanitized and are vulnerable to attacks.

Issue Number: N/A

What is the new behavior?

Referer, TraceID, and User-Agent are now sanitized.

@italolelis italolelis added the bug Something isn't working label Dec 14, 2021
@italolelis italolelis self-assigned this Dec 14, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #29 (58a3621) into main (9d858f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   32.34%   32.34%           
=======================================
  Files          10       10           
  Lines         303      303           
=======================================
  Hits           98       98           
  Misses        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d858f8...58a3621. Read the comment docs.

@italolelis italolelis merged commit cf0c66a into main Dec 14, 2021
@italolelis italolelis deleted the fix-sanitize branch December 14, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants