updated references to deprecated policy/v1beta1 with policy/v1; re: issue #63 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've attempted to deploy this on GKE and am receiving errors about missing policies under policy/v1beta1, specifically with regard to the PodDisruptionBudget.
The
policy/v1beta1API has been deprecated in v1.21 and since fully removed as of v1.25 in favour of the stablepolicy/v1API: https://cloud.google.com/kubernetes-engine/docs/deprecations/apis-1-25#poddisruptionbudget-v125I then found the issue #63
I've replaced any occurrences of v1beta1 for the relevant policy with
v1and built the project successfully, but I am not experienced with Go so I apologise if there are any issues introduced.