Fix last/0 definition to make pick(last) works

itchyny · Aug 13, 2023 · 6920005 · 6920005
1 parent 1d37721
commit 6920005
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/builtin.jq b/src/builtin.jq
@@ -168,7 +168,7 @@ def nth($n; g):
   if $n < 0 then error("nth doesn't support negative indices")
   else label $out | foreach g as $item ($n + 1; . - 1; if . <= 0 then $item, break $out else empty end) end;
 def first: .[0];
-def last: .[-1];
+def last: .[length-1];
 def nth($n): .[$n];
 def combinations:
     if length == 0 then [] else

diff --git a/tests/jq.test b/tests/jq.test
@@ -1051,8 +1051,11 @@ pick(first|first)
 [[10,20],30]
 [[10]]
 
-# negative indices in path expressions (since last/1 is .[-1])
-try pick(last) catch .
+pick(last)
+[1,2]
+[null,2]
+
+try pick(.[-1]) catch .
 [1,2]
 "pick/1 does not support negative indices and array slicing"