Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingame scoreboard #155

Merged
merged 3 commits into from
Oct 13, 2016
Merged

Add ingame scoreboard #155

merged 3 commits into from
Oct 13, 2016

Conversation

mad-s
Copy link
Contributor

@mad-s mad-s commented Nov 29, 2015

No description provided.

@itdelatrisu
Copy link
Owner

Thanks a lot! I really appreciate all the help -- I've been meaning to add a bunch of the features you've been writing for a long time.

Would you mind improving the appearance of this before I merge it, though? (I can do this if you don't want to, though I don't think I'll have any spare time for a while -- just let me know.) For reference, here's how osu! looks now:
image
So, a semi-transparent background (image?), some padding, commas in the numbers, and changing the combo text placement would do it.

Also, as for fading in/out: in osu!, the scoreboard fades smoothly when pressing tab, and it will always be displayed during breaks regardless (though I don't really care for this last part).

Lastly, this happens when there are a lot of clustered scores: https://www.youtube.com/watch?v=9TdOLlAhg6w

@mad-s
Copy link
Contributor Author

mad-s commented Nov 29, 2015

Yes, I can improve it tomorrow afternoon. I think the clustered scores are too much of a problem, also it would require a more sophisticated animation system. Also one could decrease the animation time to mask the issue.

@mad-s
Copy link
Contributor Author

mad-s commented Nov 30, 2015

I made the scoreboard fade as well as being visible during breaks. A also added commas and moved the combo text to the right. The scoreboard can handle up to 999'999'999 score and 9'999x combo without overlapping or connecting, I think that is enough.

@honard
Copy link

honard commented Dec 15, 2015

(I know this is a stupid question but)
When will you release the New Updated Android Version of opsu! ?

thanks for replying ^-^

@iceblade112
Copy link
Contributor

@honard Late reply, but @itdelatrisu doesn't actually maintain the Android version like the normal PC version.

@itdelatrisu
Copy link
Owner

Sorry for the super late response on this -- finally had a chance to look at this, will merge and make a follow-up. Thanks so much!

@itdelatrisu itdelatrisu merged commit 21579da into itdelatrisu:master Oct 13, 2016
itdelatrisu added a commit that referenced this pull request Oct 13, 2016
Some code cleanup and tweaks to the scoreboard display.
itdelatrisu added a commit that referenced this pull request Oct 14, 2016
Previous fix (#186) threw NPE upon failing a song.  Thanks to #155.

Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants