Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulse main menu logo to the beat, add pulsing logo in song menu #214

Merged
merged 12 commits into from
Dec 20, 2016

Conversation

yugecin
Copy link
Contributor

@yugecin yugecin commented Dec 18, 2016

close #163 when merged
I made it pulse at 1Hz when music is paused, which may look a bit weird with the scaling. Adjust if needed.

@Lemmmy
Copy link
Contributor

Lemmmy commented Dec 18, 2016

1Hz should be fine IMO - the menu pulses at 60bpm (1Hz) wehn nothing is playing in osu! too.

@itdelatrisu
Copy link
Owner

Looks great! Good job with the logic to get the beats -- I'd never thought about doing it this way.

Some comments:

  • The parseOnlyTimingPoints() method doesn't need MD5InputStreamWrapper since it's not computing the file's MD5 hash.
  • In the song menu in osu!, you can click the logo to start the game (call startGame()). Also, hovering over the logo makes it stop pulsing and scales it to ~140% (can't tell exactly).

@yugecin
Copy link
Contributor Author

yugecin commented Dec 19, 2016

Thanks :)
I removed the MD5 wrapper and made the logo a button. When the logo is expanded, the non-expanded hitbox is still used like in osu!. The scale was indeed 140%

@itdelatrisu
Copy link
Owner

Thanks! :)

@itdelatrisu itdelatrisu merged commit 0f936d3 into itdelatrisu:master Dec 20, 2016
itdelatrisu added a commit that referenced this pull request Dec 20, 2016
Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
itdelatrisu added a commit that referenced this pull request Dec 20, 2016
Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
@yugecin yugecin deleted the pusing-logo branch December 20, 2016 07:26
itdelatrisu added a commit that referenced this pull request Dec 22, 2016
Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
itdelatrisu added a commit that referenced this pull request Dec 23, 2016
Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Bumping Effects on opsu! logo
3 participants