-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulse main menu logo to the beat, add pulsing logo in song menu #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Hz should be fine IMO - the menu pulses at 60bpm (1Hz) wehn nothing is playing in osu! too. |
Looks great! Good job with the logic to get the beats -- I'd never thought about doing it this way. Some comments:
|
Thanks :) |
Thanks! :) |
itdelatrisu
added a commit
that referenced
this pull request
Dec 20, 2016
Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
itdelatrisu
added a commit
that referenced
this pull request
Dec 20, 2016
Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
itdelatrisu
added a commit
that referenced
this pull request
Dec 22, 2016
itdelatrisu
added a commit
that referenced
this pull request
Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #163 when merged
I made it pulse at 1Hz when music is paused, which may look a bit weird with the scaling. Adjust if needed.