Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key overlay #307

Merged
merged 11 commits into from
Jul 1, 2017
Merged

Key overlay #307

merged 11 commits into from
Jul 1, 2017

Conversation

yugecin
Copy link
Contributor

@yugecin yugecin commented Jun 28, 2017

Notes

  • osu! adds a text shadow, I couldn't find a decent way to do this (I commented a method to do this). This shadow is very useful when the text is colored white.
  • I'm not sure how to correctly position/scale the background, it does not show correctly with some skins.

@itdelatrisu
Copy link
Owner

Thanks as usual, looks great! But you forgot to commit the images. 😛

I'd prefer the InputOverlayKey class to go in a separate file (perhaps in itdelatrisu.opsu.ui) since Game.java is already way too long.

@yugecin
Copy link
Contributor Author

yugecin commented Jul 1, 2017

Whoops, added them (yugecin's law again >.<)
I also thought it should be in a separate file, but didn't know where to put it. Moved it now.

@itdelatrisu
Copy link
Owner

Awesome, thanks! :)

@itdelatrisu itdelatrisu merged commit da5a366 into itdelatrisu:master Jul 1, 2017
@yugecin yugecin deleted the keyoverlay branch July 1, 2017 21:47
itdelatrisu added a commit that referenced this pull request Jul 1, 2017
Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants