Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display beatmap's source on song select #331

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

Lyonlancer5
Copy link
Contributor

Updates the display on the song and main menus to display where the audio came from (e.g. 東方Project, Nico Nico Douga, ラブライブ! School idol project etc.)

Expect use of Unicode characters as beatmap.source is not limited to English.

@tpenguinltg
Copy link
Contributor

Just curious, is this how osu! displays the source?

Perhaps this should be available behind a pref? I already know where my songs come from, so I, for one, don't really care to see the source, especially if it's full of kanji that I can't read.

@Lyonlancer5
Copy link
Contributor Author

song-select

Its close to how osu! displays the source in its user interface.

I had put the source display to maintain the completeness of the osu! UI even on different platforms, plus the fact that osu!'s search functionality also takes into account the beatmap source (to those who can read/type it)

If you want it behind a setting, I can put it just under the "Prefer metadata in original language" setting to maintain a sort-of right flow.

@tpenguinltg
Copy link
Contributor

Parity is good, which means if this were a setting, it should probably be on by default. I'd defer to @itdelatrisu for the placement of the setting (if he even wants one), but I agree that it would go there.

The code otherwise looks good.

@itdelatrisu itdelatrisu merged commit faad9f4 into itdelatrisu:master Feb 12, 2018
@itdelatrisu
Copy link
Owner

Merged, sorry for the terribly late response on this.

@Lyonlancer5 Lyonlancer5 deleted the extended-metadata branch March 10, 2018 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants