Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ClassificationMetrics to emloop #51

Merged
merged 10 commits into from
Jan 10, 2019
Merged

Move ClassificationMetrics to emloop #51

merged 10 commits into from
Jan 10, 2019

Conversation

gdynusa
Copy link
Contributor

@gdynusa gdynusa commented Jan 3, 2019

Once merged, emloop-scikit should be deleted

@gdynusa gdynusa requested a review from petrbel January 3, 2019 08:46
@coveralls
Copy link

coveralls commented Jan 3, 2019

Pull Request Test Coverage Report for Build 1104

  • 26 of 71 (36.62%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 87.793%

Changes Missing Coverage Covered Lines Changed/Added Lines %
emloop/hooks/classification_metrics.py 13 33 39.39%
emloop/tests/hooks/classification_metrics_test.py 10 35 28.57%
Totals Coverage Status
Change from base Build 963: -0.8%
Covered Lines: 3898
Relevant Lines: 4440

💛 - Coveralls

Copy link
Member

@petrbel petrbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just one little thing

@petrbel petrbel requested a review from FloopCZ January 8, 2019 13:20
Copy link
Contributor

@FloopCZ FloopCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @petrbel for the initial work and @gdynusa for the porting!

FloopCZ and others added 5 commits January 9, 2019 13:26
Co-Authored-By: gdynusa <33875769+gdynusa@users.noreply.github.com>
Co-Authored-By: gdynusa <33875769+gdynusa@users.noreply.github.com>
Co-Authored-By: gdynusa <33875769+gdynusa@users.noreply.github.com>
Co-Authored-By: gdynusa <33875769+gdynusa@users.noreply.github.com>
"""
:param predicted_variable: name of the predicted variable.
:param gt_variable: name of the ground truth variable
:param f1_average: averaging type {binary, micro, macro, weighted, samples} defined by
`sklearn.metrics.precision_recall_fscore_support`
https://scikit-learn.org/stable/modules/generated/sklearn.metrics.precision_recall_fscore_support.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a proper rst link instead.

Copy link
Contributor

@FloopCZ FloopCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this, thank you guys!

@petrbel petrbel merged commit 87a93eb into dev Jan 10, 2019
@petrbel petrbel deleted the scikit branch January 10, 2019 08:30
@FloopCZ FloopCZ mentioned this pull request Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants