Fix duplicate anchors #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1250
💛 - Coveralls |
petrbel
reviewed
Jan 23, 2019
emloop/utils/yaml.py
Outdated
| @@ -52,7 +52,7 @@ def make_simple(data: Any) -> Any: | |||
| :param data: data to be made simple (dict instead of CommentedMap etc.) | |||
| :return: simplified data | |||
| """ | |||
| return yaml.load(yaml.dump(data, Dumper=ruamel.yaml.RoundTripDumper), Loader=ruamel.yaml.Loader) | |||
| return dict(data) | |||
There was a problem hiding this comment.
if this works (not sure), than the whole make_simple is useless and dict should be used instead
There was a problem hiding this comment.
Agreed. @bedapisl claims that the original issue with dict cast is fixed.
FloopCZ
approved these changes
Jan 24, 2019
|
Well... this will not convert anything nested right?... |
|
I don't know what exactly you mean, but the class we are converting is nested in a way (it represents nested yaml configuration) and it looks like it is converted correctly. |
|
I actually don't remember why we need the conversion whatsoever. Maybe we can skip the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filip: The example in https://github.com/Cognexa/cxflow/pull/222 works for me now, so this code should work too.