Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI difference Windows/macOS for URL field in connection window #16369

Closed
AliveDevil opened this issue Sep 23, 2024 · 0 comments · Fixed by #16373
Closed

UI difference Windows/macOS for URL field in connection window #16369

AliveDevil opened this issue Sep 23, 2024 · 0 comments · Fixed by #16373
Labels
Milestone

Comments

@AliveDevil
Copy link
Contributor

Nonetheless, the displayed url should represent the expected format of protocol://identity@host.

#16366 (comment)

Since 6295e00 the macOS bookmark window doesn't contain the username anymore, but the change on the bookmark model had no effect:

View.URL = new HostUrlProvider(true, true).get(_host);
is the last change for setting the URL field.

Thus on Windows the username is still included in the URL field, while on macOS the username is omitted.
People might be confused by the username missing in the URL field.
Reintroduce identity component to displayed URL text.

@AliveDevil AliveDevil added interface User Interface enhancement cyberduck Cyberduck labels Sep 23, 2024
@dkocher dkocher linked a pull request Sep 23, 2024 that will close this issue
@dkocher dkocher added this to the 9.1 milestone Sep 23, 2024
dkocher added a commit that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants