New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add copy method to drive.py #188

Merged

shcheklein merged 19 commits into iterative:master from simone-viozzi:add-copy-method

Jul 19, 2022

Contributor

simone-viozzi commented Jul 2, 2022

Hi i added the copy method keeping it as simple as possible.

this PR fixes #83 #53

shcheklein reviewed

View reviewed changes

pydrive2/drive.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/drive.py Outdated Show resolved Hide resolved

shcheklein requested changes

View reviewed changes

Member

shcheklein left a comment

Thanks for the PR! I've left a comment. Primarily next step is to move it to the GoogleDriveFile class and we'll need to add tests.

simone-viozzi commented

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

simone-viozzi requested a review from shcheklein

July 5, 2022 11:13

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein requested changes

View reviewed changes

Member

shcheklein left a comment

good progress :) please, see some comments + we still need to add tests for this

Contributor Author

simone-viozzi commented Jul 6, 2022 •

edited

Loading

Where the test should go? on test_file.py or test_fs.py?
they have very different structure

also, I can't seem to run the existing ones :) but is most likely because of the authentication.

simone-viozzi requested a review from shcheklein

July 7, 2022 18:21

shcheklein reviewed

View reviewed changes

pydrive2/drive.py Outdated Show resolved Hide resolved

simone-viozzi requested a review from shcheklein

July 12, 2022 15:28

shcheklein reviewed

View reviewed changes

pydrive2/drive.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Show resolved Hide resolved

shcheklein requested changes

View reviewed changes

Member

shcheklein left a comment

Good progress! Please take a look at the latest review.

simone-viozzi requested a review from shcheklein

July 13, 2022 21:17

shcheklein reviewed

View reviewed changes

pydrive2/files.py Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/test/test_file.py Outdated Show resolved Hide resolved

Member

shcheklein commented Jul 18, 2022

The documentation of the function itself are generated from the doc-string, right?

Yes, but I would see if there are mentions in those rsts. If not - that's fine.

If you can do a quick example - that would be great! If not that's also fine- not a blocker. Just let me know when you feel you are ready with that, and we'll merge it.

simone-viozzi added 19 commits

July 18, 2022 18:26


          add copy method to drive.py

d2034ed


          removed kind

4a7ff00


          moved the copy method to files.py

bc14d1a


          add try except around the API call

92eac3e


          corrected some single quote in double quote

d8fa544


          removed newline at the end of the file

dbdba60


          added param to copy method

d74e921


          first try on the test

f98893d


          test + fix bugs on copy method

1c636a0


          fixed not modified file with git, so it doesn't show up on the changes

89e215e


          solved some comments

e8f8c20

- fixed style
- fixed docstring
- now the function will return the copied file
- if new_title is None the new title will be "Copy of [old-title]"


          target_folder is now optional

53866ef


          edits on the copyFile tests

a9c3f5c

- now i use the ability to return the copied file directly
- adding new test to copy the file in a different folder


          clarified code a bit

b753278


          add comment

032f754


          changed description of Copy method

5c5f5c0


          runned pre-commit hook and fixed pydrive_retry

366ba6f


          changed SetContentString to SetContentFile

23f81b7


          fixed docstring

a34abe0

shcheklein force-pushed the add-copy-method branch from 741ac0a to a34abe0 Compare

July 19, 2022 01:26

shcheklein temporarily deployed to external

July 19, 2022 01:26

Inactive

shcheklein temporarily deployed to external

July 19, 2022 04:10

Inactive

Contributor Author

simone-viozzi commented Jul 19, 2022

@shcheklein let's merge it like this. I plan to add other methods too like rename and move, so maybe I will do an example use case with those too.

shcheklein approved these changes

View reviewed changes

shcheklein merged commit 4a6590c into iterative:master

Member

shcheklein commented Jul 19, 2022

@simone-viozzi done, thanks for the PR.

simone-viozzi deleted the add-copy-method branch

July 19, 2022 14:39

shcheklein mentioned this pull request

how to implement makeCopy of shared file #53

Closed

simone-viozzi mentioned this pull request

Implement mv method in GDriveFileSystem #217

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet