auth: add client_json and client_json_dict #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Jul 18, 2022
|
|
||
| if not keyfile_dict and keyfile_json: | ||
| # Compensating for missing ServiceAccountCredentials.from_json_keyfile | ||
| keyfile_dict = json.loads(keyfile_json) |
There was a problem hiding this comment.
Note, from_json_keyfile_name is naively loading the json too and any errors pass right through. Same here.
efiop
commented
Jul 18, 2022
Comment on lines
+76
to
+78
| client_json_file_path: {{str}} | ||
| client_json_dict: {{dict}} | ||
| client_json: {{str}} |
There was a problem hiding this comment.
I understand that having all three might seem excessive, but it is really useful and in sync with the flexibility that ServiceAccountCredentials.from_json* provides.
efiop
commented
Jul 18, 2022
shcheklein
reviewed
Jul 18, 2022
shcheklein
reviewed
Jul 18, 2022
shcheklein
reviewed
Jul 18, 2022
shcheklein
reviewed
Jul 18, 2022
shcheklein
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client_creds_dictwas introduced in experimental mode before (a few days back) and wasn't documented. Renaming it intoclient_json_dictto be consistent with other options.Introducing
client_jsonfor convenience to syncronize with oauth2 storage options so that users can use either dict or json and not be forced to use both of them when authenticating.