pyinstaller: add package hooks #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
force-pushed
the
pyinstaller-hooks
branch
from
80efba8 to
0fa1eb3
Compare
pmrowla
commented
Nov 15, 2022
Comment on lines
+10
to
+11
| repo: https://github.com/PyCQA/flake8 | ||
| rev: 5.0.4 |
There was a problem hiding this comment.
This is obviously unrelated to pyinstaller, but we should be using the github repo for flake8 (the old gitlab URL now requires auth and breaks pre-commit in CI)
|
In DVC this means we will be able to remove the DVC-level google API/client hooks, but we will still need to keep the existing pydrive2 hook (since it's a hidden import at the DVC level due to the optional dependency configuration) |
2 tasks
efiop
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds package level pyinstaller hooks so that any downstream package using pydrive2 + pyinstaller does not need to define their own hooks for the google client APIs
see details in the pyinstaller docs: https://pyinstaller.org/en/stable/hooks.html#providing-pyinstaller-hooks-with-your-package)
related:
#197
iterative/dvc#7949