Add bind_addr parameter to LocalWebserverAuth #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there doesn't seem to be a way to authenticate using the LocalWebserverAuth flow while running inside a local docker container because Docker's port forwarding doesn't help with localhost-only-bound ports. This PR adds a
bind_addrparameter, intended for you to pass"0.0.0.0"to it, basically providing the same functionality as described in googleapis/google-auth-library-python-oauthlib#202.Relatedly, the CommandlineAuth flow seems to now be completely blocked by Google, but I didn't touch that in this PR.