Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set upper bound for cryptography #364

Merged
merged 2 commits into from
Nov 29, 2024
Merged

set upper bound for cryptography #364

merged 2 commits into from
Nov 29, 2024

Conversation

skshetry
Copy link
Member

pyopenssl<24.3.0 is not compatible with cryptography<44. So, limiting them so that newer version of cryptography does not get installed with older version of pyopenssl.

Related: #361.

pyopenssl<24.3.0 is not compatible with cryptography<44. So, limiting them so that newer version of cryptography does not get installed with older version of pyopenssl.
@skshetry skshetry changed the title set lower limit for cryptography set upper bound for cryptography Nov 29, 2024
@skshetry
Copy link
Member Author

skshetry commented Nov 29, 2024

Note that this PR exists only for helping uv's resolver. uv resolves dependencies in the order they are specified, which can result in different resolutions depending on the sequence.

Example with uv:

$ uv pip install pydrive2 cryptography pyopenssl
Resolved 27 packages in 180ms
Installed 3 packages in 10ms
 + cryptography==44.0.0
 + pydrive2==1.21.2
 + pyopenssl==22.0.0

$ uv pip uninstall pydrive2 cryptography pyopenssl
$ uv pip install pydrive2 pyopenssl cryptography
Resolved 27 packages in 12ms
Installed 3 packages in 7ms
 + cryptography==43.0.3
 + pydrive2==1.21.2
 + pyopenssl==24.2.1

Compare that with pip install

$ uv pip uninstall pydrive2 cryptography pyopenssl

$ pip install pydrive2 cryptography pyopenssl
Successfully installed cryptography-43.0.3 pydrive2-1.21.2 pyopenssl-24.2.1

$ uv pip uninstall pydrive2 cryptography pyopenssl

$ pip install pydrive2 pyopenssl cryptography
Successfully installed cryptography-43.0.3 pydrive2-1.21.2 pyopenssl-24.2.1

@skshetry skshetry merged commit d88708b into main Nov 29, 2024
15 of 16 checks passed
@skshetry skshetry deleted the skshetry-patch-1 branch November 29, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant