bump google-api-python-client version to the latest #56
Conversation
|
Seems to be still affected by the same issue 🤔 |
|
Looks like we also need to force version of |
skshetry
force-pushed
the
skshetry-patch-1
branch
from
f08f144
to
6195d88
Compare
There was a recent release 1.12.0 which broke because of its dependency with `six`, and there has been another patch update `1.12.1` which fixes that. I could have just forbidden `1.12.0`, but didn't trust other versions and tried to just use the latest version.
skshetry
force-pushed
the
skshetry-patch-1
branch
from
6195d88
to
3362710
Compare
| @@ -26,7 +26,8 @@ | |||
| description="Google Drive API made easy. Maintained fork of PyDrive.", | |||
| long_description=open("README.rst").read(), | |||
| install_requires=[ | |||
| "google-api-python-client >= 1.7.12", | |||
| "google-api-python-client >= 1.12.1", | |||
| "six >= 1.13.0", | |||
There was a problem hiding this comment.
Need to update this as well, don't see a better way. We might need to do the same in dvc.
There was a problem hiding this comment.
hmmm ... I don't understand why is it needed, google-api-python-client already specifies the same dependency. Any ideas on this?
There was a problem hiding this comment.
pip does not have a resolver (yet), so it either installs top-level requirements specification (as done here) or does "first one wins" which installs six from different dependency and ignores the one specified in google-api-python-client (it does raise warning at the end).
pypa/pip#988 (comment)
|
Releasing new version... |
|
Thank you @skshetry ! 🙏 |
There was a recent release 1.12.0 which broke because of its dependency with
six,and there has been another patch update
1.12.1which fixes that. I could have just forbidden1.12.0, but didn't trust other versions and tried to just use the latest version.Recent release with the fix: https://github.com/googleapis/google-api-python-client/releases/tag/v1.12.1