Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectDB._init: Ensure self.fs.ls return is not None before iterating. #211

Closed
wants to merge 1 commit into from

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Jun 15, 2023

@daavoo daavoo self-assigned this Jun 15, 2023
@daavoo
Copy link
Contributor Author

daavoo commented Jun 15, 2023

I could do the fix instead in https://github.com/iterative/PyDrive2 but I am not sure if raising FileNotFoundError is something required to fulfill with fsspec or not.

@daavoo daavoo requested a review from a team June 15, 2023 09:48
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: +0.04 🎉

Comparison is base (7e07ccf) 64.61% compared to head (f2897f6) 64.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     iterative/dvc#211      +/-   ##
==========================================
+ Coverage   64.61%   64.66%   +0.04%     
==========================================
  Files          25       25              
  Lines        1936     1944       +8     
  Branches      305      306       +1     
==========================================
+ Hits         1251     1257       +6     
  Misses        630      630              
- Partials       55       57       +2     
Impacted Files Coverage Δ
src/dvc_objects/db.py 92.61% <33.33%> (-0.93%) ⬇️
tests/test_odb.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry
Copy link
Member

I could do the fix instead in https://github.com/iterative/PyDrive2 but I am not sure if raising FileNotFoundError is something required to fulfill with fsspec or not.

It should raise a FileNotFoundError. Let's fix on pydrive2 side.

@daavoo daavoo closed this Jun 15, 2023
@daavoo daavoo deleted the dvc-issue-9607 branch June 15, 2023 10:07
@efiop
Copy link
Contributor

efiop commented Jun 15, 2023

For the record iterative/PyDrive2#283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants