-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guide: describe the how hash values (md5
) are calculated
#68
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
More details from Ruslan
|
This comment has been minimized.
This comment has been minimized.
@efiop can you or someone from core summarize the explanation here or even submit a draft PR for this when you have some time? We can take it on from there but it would be great if someone already familiar with the exact algorithm to generate file hashes works. And/or if you can point me to the part of the code where it's done. Thanks! |
@jorgeorpinel Sure! I just wonder if this is really p1. Seems like minor internal implementation details. This ticket was created before |
@jorgeorpinel agreed with Ruslan, not sure why it was bumped to p1. |
Yeah sure, Idk either. p2 sounds good. Thanks! |
Hi! I wonder if users need to know this. What's the advantage or need to document it? Seems like an implementation detail. Or perhaps for security reasons (being able to confirm checksums)? |
In my personal case, we are working with a custom http remote that validates the checksum of the uploaded content. So being able to confirm the checksum is my personal need. |
md5
) are calculated
This seems to keep coming up in support channels (1). Bumping priority a little. Also, here's the relevant code: https://github.com/iterative/dvc/blob/aab5dec7f5f6dd16c00942285bfd229c693446b6/dvc/utils/__init__.py#L44 |
Hi @efiop do you think the current content in https://dvc.org/doc/user-guide/project-structure/dvc-files#output-entries is enough? Still not a full explanation of how it's calculated internally but that's probably too deep? If so feel free to close this. Thanks |
In fact I'm going to close this as stale for now, but please reopen if you disagree. |
Tell about how we compute checksums for files, why we dos2unix when computing md5 and how to map the md5 value found in dvcfile to an actual cache file at .dvc/cache
The text was updated successfully, but these errors were encountered: