-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decide best term for "md5" "checksum" or "hash" strings used in DVC-files, and Git commit (SHA) "hash" #552
Comments
If it is just I think that when the explanation is meant for the users (who don't need to know the internal details) the terms hash/checksum are ok. |
I agree with @dashohoxha . checksum vs hash. Hash is a better term because of the primary goal we are using these md5s for - store and find binary files in our storage. (Though we check the consistency as well). I'm fine to use checksum everywhere, especially considering that it won't be hard to switch to a new version. MD5, etag, other checksums make sense when we go into details. |
|
UPDATE: I made sure every instance of MD5 is upper case unless it's a file or command code block as part of #669.
|
Hi! Notice that per some relatively recent conversation with @shcheklein, we stopped using "checksum" in docs, in favor of terms like (MD5/ Should we apply the same in docs? Note that there is somewhat of a collision between that term and (Git) "commit hash" for which we're using "commit SHA hash" in the docs PR right now (may review that one). Cc @efiop |
@jorgeorpinel I would reconsider using |
Agree. Right now we are reducing the usage of MD5 in docs because AFAIK our file hashes are not always direct MD5 (and this is still not properly explained, see #68) |
* cmd ref: copy edits and improve `move` examples, adding one with `import` related to https://discordapp.com/channels/485586884165107732/485596304961962003/676360262416203776 * tutorials: correct section title in versioning per #933 (comment) * term: review "point" (file hash context) per #552 (comment)
and implement throughout the docs.
Notes:
md5
) are calculated #68Oh and let's try to use upper case "MD5", not "md5" when possible.
hash: May be too general a term?(Also applies to Git commit SHA-1 hashes)UPDATE: See decide best term for "md5" "checksum" or "hash" strings used in DVC-files, and Git commit (SHA) "hash" #552 (comment) + below.
The text was updated successfully, but these errors were encountered: