Fix #10593 -- add --keep option for dvc experiments remove#10633

Merged

shcheklein merged 25 commits intoiterative:mainfrom rmic:fix-10593

Nov 30, 2024

+118-2

Commits on Nov 29, 2024

Add keep_selected parameter, and corresponding code to keep only the selected exps (and remove all the other ones)

rmic
authored and
skshetry
committed
test keep_selected_by_name

rmic
authored and
skshetry
committed
test keep_selected_by_rev

rmic
authored and
skshetry
committed
test keep_selected multiple, by name

rmic
authored and
skshetry
committed
test keep all by name

rmic
authored and
skshetry
committed
test keep by rev, with num=2

rmic
authored and
skshetry
committed
added option to cli

rmic
authored and
skshetry
committed
refactoring to meet pr needs

rmic
authored and
skshetry
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
skshetry
committed
fixed test_experiments to add keep_selected=False to remove tests

rmic
authored and
skshetry
committed
rename parameter to match cli option

rmic
authored and
skshetry
committed
follow the normal path, then invert the selection before removing

rmic
authored and
skshetry
committed
fixed tests for list ordering + fixed test with non existent name, it didn't make sense to delete everything if an exp name did not exist

rmic
authored and
skshetry
committed
changed cli option comment

rmic
authored and
skshetry
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
skshetry
committed
fixed typing issue

rmic
authored and
skshetry
committed
updated parameter name

rmic
authored and
skshetry
committed
removed handling queued experiments (since --queue would remove them all)

rmic
authored and
skshetry
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
skshetry
committed
code simplification, added __eq__ and __hash__ to be able to compare ExpRefs, updated and parametrized tests.

rmic
authored and
skshetry
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
skshetry
committed
fixed linting issues

rmic
authored and
skshetry
committed
- --keep and --queue together raise an InvalidArgumentError

rmic
authored and
skshetry
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
skshetry
committed
re-run gh tests. Some tests which did not involve my changes started failing while they were passing fine before.

rmic
authored and
skshetry
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #10593 -- add --keep option for dvc experiments remove#10633

Commits on Nov 29, 2024

Add keep_selected parameter, and corresponding code to keep only the selected exps (and remove all the other ones)

test keep_selected_by_name

test keep_selected_by_rev

test keep_selected multiple, by name

test keep all by name

test keep by rev, with num=2

added option to cli

refactoring to meet pr needs

[pre-commit.ci] auto fixes from pre-commit.com hooks

fixed test_experiments to add keep_selected=False to remove tests

rename parameter to match cli option

follow the normal path, then invert the selection before removing

fixed tests for list ordering + fixed test with non existent name, it didn't make sense to delete everything if an exp name did not exist

changed cli option comment

[pre-commit.ci] auto fixes from pre-commit.com hooks

fixed typing issue

updated parameter name

removed handling queued experiments (since --queue would remove them all)

[pre-commit.ci] auto fixes from pre-commit.com hooks

code simplification, added eq and hash to be able to compare ExpRefs, updated and parametrized tests.

[pre-commit.ci] auto fixes from pre-commit.com hooks

fixed linting issues

- --keep and --queue together raise an InvalidArgumentError

[pre-commit.ci] auto fixes from pre-commit.com hooks

re-run gh tests. Some tests which did not involve my changes started failing while they were passing fine before.