Fix #10638 : makes remove return correct list when used with both --queue
and -A
#10641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #10638, by providing a minimal code fix that makes the
--all-commits
(aka.-A
flag) append to the existingremoved
list instead of replacing it with a new value.When
--queue
is used, it might already contain the names of experiments removed from the queue. In all other cases, the list should exist but be empty, so appending still makes the job correctly.Checklist
❗ I have followed the Contributing to DVC checklist.
[N/A] 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏