Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10638 : makes remove return correct list when used with both --queue and -A #10641

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

rmic
Copy link
Contributor

@rmic rmic commented Nov 30, 2024

Description

This PR addresses issue #10638, by providing a minimal code fix that makes the --all-commits(aka. -A flag) append to the existing removed list instead of replacing it with a new value.

When --queue is used, it might already contain the names of experiments removed from the queue. In all other cases, the list should exist but be empty, so appending still makes the job correctly.

Checklist

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@rmic rmic changed the title Fix #10638 : makes --queue work with -A Fix #10638 : makes remove return correct list when used with both --queue and -A Nov 30, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (2431ec6) to head (c2414b8).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10641      +/-   ##
==========================================
+ Coverage   90.68%   91.02%   +0.34%     
==========================================
  Files         504      504              
  Lines       39795    39858      +63     
  Branches     3141     3152      +11     
==========================================
+ Hits        36087    36281     +194     
+ Misses       3042     2948      -94     
+ Partials      666      629      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmic rmic marked this pull request as ready for review November 30, 2024 21:39
@shcheklein
Copy link
Member

thanks, @rmic

@rmic
Copy link
Contributor Author

rmic commented Dec 1, 2024

thanks, @rmic

You're welcome ! Thanks for your guidance and patience 🙂

@shcheklein shcheklein merged commit 198c8f2 into iterative:main Dec 1, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants