dvc: preserve desc on add/run/imp #5003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Dec 1, 2020
| @@ -161,6 +161,7 @@ def compute_md5(stage): | |||
| # Remove md5 and meta, these should not affect stage md5 | |||
| d.pop(stage.PARAM_MD5, None) | |||
| d.pop(stage.PARAM_META, None) | |||
| d.pop(stage.PARAM_DESC, None) | |||
There was a problem hiding this comment.
Forgot about it the last time 🤦♂️ 🤦♂️ 🤦♂️
efiop
commented
Dec 1, 2020
|
|
||
| run_copy("foo1", "bar1", single_stage=True, force=True, fname="bar.dvc") | ||
| # CRLF on windows makes the generated file bigger in size |
There was a problem hiding this comment.
Related #4658 One more point is that our md5s go through dos2unix, but sizes don't, so md5 <-> size relations are not constant :( We'll be looking at it soon in 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4907
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏