Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast path to string #619

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Cast path to string #619

merged 1 commit into from
Jul 5, 2023

Conversation

CptCaptain
Copy link
Contributor

In some cases this might be a PosixPath, causing issues downstream.

Fixes #618

in some cases this might be a PosixPath, causing issues downstream
@daavoo
Copy link
Contributor

daavoo commented Jul 5, 2023

I am not sure in which scenarios this is failing, though.
Tried to add a test but self._dvc_repo.add(path) doesn't fail.

@CptCaptain Could you share your DVC version?

@CptCaptain
Copy link
Contributor Author

Sure, I'm using these versions:

dvc==2.58.2
dvc-data==0.51.0
dvc-gs==2.22.1
dvc-http==2.30.2
dvc-objects==0.23.0
dvc-render==0.5.3
dvc-studio-client==0.11.0
dvc-task==0.3.0
dvclive==2.12.0

This all runs from the ultralytics repo, if that makes a difference.

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, appears to be some issue that has been resolved in more recent DVC versions (in the latest version the error doesn't appear).

I am able to reproduce this when installing those pinned dependencies.

@daavoo daavoo merged commit 26524fd into iterative:main Jul 5, 2023
@skshetry
Copy link
Member

skshetry commented Jul 5, 2023

This was fixed in dvc 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache_images issues
3 participants