Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for fsspec 2024.5.0 #34

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix for fsspec 2024.5.0 #34

merged 1 commit into from
Jun 5, 2024

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jun 5, 2024

fsspec==2024.5.0 replaced mv_file with mv in fsspec/filesystem_spec#1585. This commit adds compat for all supported fsspec versions, including the latest.

  • Also enable support for Python 3.13,
  • Uses uv.
  • Remove safety.

@skshetry skshetry force-pushed the fsspec-2024.5.0-fix branch from 0d0909d to 86df801 Compare June 5, 2024 04:12
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (602da4c) to head (86df801).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.01%     
==========================================
  Files           8        8              
  Lines         922      923       +1     
  Branches      171      171              
==========================================
+ Hits          786      787       +1     
  Misses        128      128              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry force-pushed the fsspec-2024.5.0-fix branch from 86df801 to af5e362 Compare June 5, 2024 04:14
fsspec==2024.5.0 replaced mv_file with mv. This commits adds compat
for both.

Also enable support for Python 3.13, and use uv.
@skshetry skshetry force-pushed the fsspec-2024.5.0-fix branch from af5e362 to c593a96 Compare June 5, 2024 04:15
@skshetry skshetry merged commit 00ec637 into main Jun 5, 2024
20 checks passed
@skshetry skshetry deleted the fsspec-2024.5.0-fix branch June 5, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants