Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize dictfs.ls #8

Merged
merged 1 commit into from
Aug 28, 2022
Merged

optimize dictfs.ls #8

merged 1 commit into from
Aug 28, 2022

Conversation

skshetry
Copy link
Member

ls is now not sorted by default. With ls not sorting, this is now faster than TrieFS. There is sort=True|False to enable/disable sorting.

Also some of the changes to mirror changes from fsspec/filesystem_spec#995 in fs.open(), to avoid copy.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2022

Codecov Report

Merging #8 (e0442d0) into main (20f02c9) will decrease coverage by 0.24%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   66.73%   66.49%   -0.25%     
==========================================
  Files           7        7              
  Lines         971      970       -1     
  Branches      200      199       -1     
==========================================
- Hits          648      645       -3     
- Misses        315      316       +1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
src/morefs/dict.py 91.62% <66.66%> (-0.92%) ⬇️
tests/test_dictfs.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ls is now not sorted by default. With ls not sorting, this is now faster than TrieFS.
@skshetry skshetry force-pushed the optimize-ls-find-open branch from 9291628 to e0442d0 Compare August 28, 2022 13:25
@skshetry skshetry changed the title optimize DictFS ls optimize dictfs.ls Aug 28, 2022
@skshetry skshetry merged commit 622c874 into main Aug 28, 2022
@skshetry skshetry deleted the optimize-ls-find-open branch August 28, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants