Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Google Cloud credential detection #502

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Apr 14, 2022

There is no need of duplicating the behavior of the google.FindDefaultCredentials function.

The only custom credential source we introduce is GOOGLE_APPLICATION_CREDENTIALS_DATA and only because it's not supported yet:

@0x2b3bfa0 0x2b3bfa0 added the technical-debt Refactoring, linting & tidying label Apr 14, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd April 14, 2022 01:08
@0x2b3bfa0 0x2b3bfa0 self-assigned this Apr 14, 2022
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@0x2b3bfa0
Copy link
Member Author

Waiting for @dacbd approval before merging, because this cascades on his pull request.

@dacbd dacbd merged commit 676fb66 into gcp-oidc Apr 14, 2022
@dacbd dacbd deleted the gcp-oidc-cleanup branch April 14, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants