Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that 'portrait' is not the only orientation on Chrome for Android in manifest.json #37

Closed
wants to merge 3 commits into from
Closed

Ensured that 'portrait' is not the only orientation on Chrome for Android in manifest.json #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8827ef4
Ensured that 'portrait' is not the only chrome orientation
Apr 4, 2015
1cb4f9a
Updated defaults.json and README for androidOrientation setting
Apr 8, 2015
0041ea9
Add option to configure the display mode for Android Chrome
Apr 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion data/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
"silhouette": false,
"version": 1.0,
"config": null,
"logging": false
"logging": false,
"androidOrientation": null,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default should be "portrait"

"androidDisplay": null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default should be "standalone"

},
"favicon_generation": null
}
2 changes: 2 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@
config.data.favicon_generation.favicon_design.android_chrome.theme_color = options.settings.background;
config.data.favicon_generation.favicon_design.android_chrome.manifest.name = options.settings.appName;
config.data.favicon_generation.favicon_design.android_chrome.manifest.start_url = options.settings.index;
config.data.favicon_generation.favicon_design.android_chrome.manifest.orientation = options.settings.androidOrientation;
config.data.favicon_generation.favicon_design.android_chrome.manifest.display = options.settings.androidDisplay;
config.data.favicon_generation.favicon_design.android_chrome.manifest.existing_manifest = options.files.androidManifest;
} else {
delete config.data.favicon_generation.favicon_design.android_chrome;
Expand Down
4 changes: 3 additions & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ To keep things organised, the configuration object contains 4 sub-objects: `file
index: null, // Path for the initial page on the site. `string`
url: null, // URL for your website. `string`
silhouette: false, // Turn the logo into a white silhouette for Windows 8. `boolean`
logging: false // Print logs to console? `boolean`
logging: false, // Print logs to console? `boolean`
androidOrientation: null, // Sets the orientation in manifest.json for Android Chrome `string`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, default should be "portrait"

androidDisplay: null // Sets the display value in manifest.json for Android Chrome `string`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, default should be "standalone"

},
favicon_generation: null, // Complete JSON overwrite for the favicon_generation object. `object`
}
Expand Down