Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globby now uses ESM #464

Closed
lucavb opened this issue Jul 27, 2021 · 5 comments · Fixed by #465
Closed

Globby now uses ESM #464

lucavb opened this issue Jul 27, 2021 · 5 comments · Fixed by #465

Comments

@lucavb
Copy link
Contributor

lucavb commented Jul 27, 2021

Hey,

in your package.json you specified to use the latest version of globby. However, they recently updated to version 12, which is a major update, and have turned their package into a pure ESM module and now the tests for webfont fail do as well as our usage. The import needs to be updated in webfont. Maybe I have time for this this evening. Also why did you opt for using latest for dependencies? That feels a bit risky to me and leaves you open to events such as this.

@Schascha
Copy link

A downgrade to 9.0.0 will help for now.

@lucavb
Copy link
Contributor Author

lucavb commented Jul 27, 2021

Yes and no. Version 9 was not written in TypeScript and does not have a @types/ package.

@wszydlak
Copy link
Contributor

I agree that this package should not use latest versions. It is very risky.

wszydlak pushed a commit to wszydlak/webfont that referenced this issue Jul 27, 2021
wszydlak pushed a commit to wszydlak/webfont that referenced this issue Jul 27, 2021
wszydlak pushed a commit to wszydlak/webfont that referenced this issue Jul 27, 2021
@wszydlak
Copy link
Contributor

I've prepared pull to use correct dependencies versions in #465

This should be released as patch.

webfont still needs to bump globby and meow

@jimmyandrade
Copy link
Collaborator

@wszydlak thank you so much.

v11.2.17 is now available at npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants