fix: improve compiler compatibility and warnings #647
Merged
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 10, 2024 10:56
- Replace GNUC macro check with __GNUC_PREREQ(4, 1) for more precise version control - Add fallback definition for __GNUC_PREREQ macro when not available
- Add explicit (unsigned int) casting to tv_sec and tv_nsec/tv_usec calculations to prevent potential integer overflow
- Add (void) cast and inline qualifier to eliminate unused warnings
ithewei
reviewed
Dec 18, 2024
| @@ -57,7 +57,7 @@ static inline bool atomic_flag_test_and_set(atomic_flag* p) { | |||
| #define ATOMIC_INC InterlockedIncrement | |||
| #define ATOMIC_DEC InterlockedDecrement | |||
|
|
|||
| #elif defined(__GNUC__) | |||
| #elif __GNUC_PREREQ(4, 1) | |||
There was a problem hiding this comment.
libhv限定了gcc编译器版本需要>=4.8，所以这里判断gcc版本我觉得没有太大必要性
There was a problem hiding this comment.
我明白你的意思。不过，我从使用者的角度来看，我有项目仍在使用 GCC 4.1 以下的版本，使用 libhv 库时需要进行移植。
为了提高库的兼容性，我希望最好能够保留这段代码。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
变更内容
__GNUC_PREREQ检查以支持原子操作（需要 GCC 4.1+）gettick_ms()中添加显式类型转换以修复整数溢出风险Changes
__GNUC_PREREQcheck for atomic operations (requires GCC 4.1+)gettick_ms()with explicit type casting