Manually flush & invalidate session upon completion

[ghost]

Our application downloads ~1000 items from an API ranging from sizes of 2mb - 100mb, while doing so on iOS14 the device regularly returned error 28 - no space left on device

We raised an issue (#937) and while investigating a fix we discovered that this error doesn't always mean the literal – https://github.com/AFNetworking/AFNetworking/issues/4313#issuecomment-437216801

Since the library creates a new instance of Downloader per file download we've come to a conclusion that iOS14 doesn't flush the URLSessions quick enough when they're complete so we've added this manually.

[n-sviridenko]

Any updates on this? We'd love it to be delivered as we're facing the same issue now.

[joshuaellis]

I wouldn't count on it, the last update on the repo was march 2020, meanwhile we're all running the latest version which was released oct 2019. I submitted this PR last year and haven't heard anything, not even a request for changes.

[n-sviridenko]

how did you solve it at the end?

[joshuaellis]

The code I wrote was a fix we used in our applicaiton. Hence why I submitted a PR.

[n-sviridenko]

Thanks for your commitment @joshuaellis ! Let us try this one too.

[mataspetrikas]

@joshuaellis @n-sviridenko I have tried compiling it but XCode 12.3 complains:
No visible @interface for 'NSURLSession' declares the selector 'flushWithCompletitonHandler:'

[n-sviridenko]

Fixed this in #972

[n-sviridenko]

@itinance we need you 🦸‍♂️

[itinance]

Thank you very much guys. I'm going to close this in favour of #972. Many thanks anyways!

[itinance]

(and sorry for being late here, this year was going to start very crazy)

[nijarv]

Hey guys, any help??? I use react-native-fs(2.20.0) and I'm still facing this issue when I download images and videos even though I have gb's of space left in my device I get "The operation couldn’t be completed. No space left on device".

iPhone Version : iPhone 12 Mini
iOS Version : iOS 17.0.3
Mac Version : MacBook Pro 13-inch, M1, 2020
Mac OS Version : Sonoma 14.0
Xcode Version : 15.0
NPM Version : 2.20.9
react : 18.2.0
react-native : 0.71.10

Code:

let path = RNFS.DocumentDirectoryPath + '/image.png';

RNFS.downloadFile({ fromUrl: eachTemplate.uri, toFile: path }).promise.then((resp) => {
                if (resp.statusCode === 200)
                  setImagePath(path);
              }).catch((err) => {
                console.log(err);
              });