Fix copyAssetsFileIOS's image resizing option to resize to exact width and height #975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copyAssetsFileIOS
acceptswidth
andheight
and resizes image when copying from Camera Roll.However currently it doesn't respect
width
andheight
, and copied image may or may not have width and height that matchwidth
andheight
. That's becausecopyAssetsFileIOS
usesPHImageRequestOptionsResizeModeFast
option which makesrequestImageForAsset
method efficiently resize the image to a size similar to, or slightly larger than, the target size.react-native-fs/RNFSManager.m
Lines 808 to 816 in f2f8f4a
This pull request changes the option from
PHImageRequestOptionsResizeModeFast
toPHImageRequestOptionsResizeModeExact
which makesrequestImageForAsset
method resize the image to match the target size, i.e.width
andheight
, exactly.