Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESM support #33

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Add ESM support #33

merged 3 commits into from
Sep 4, 2024

Conversation

giuseppeg
Copy link

Add ESM support for the legacy compiler (no Vite).

Replaces #29

@giuseppeg
Copy link
Author

@itsMapleLeaf it would be great if you could add your formatter configuration to the repo such that formatting is consistent otherwise the script will probably use my personal config

@itsMapleLeaf
Copy link
Owner

I'll take a closer look at this later, thanks for the PR!

@giuseppeg
Copy link
Author

@itsMapleLeaf thanks! If you add the formatter config on main I will rebase and format again, so it'll be easier to go through the changes.

}: InitRemixOptions): Promise<string> {
const appRoot = app.getAppPath()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the electron app root not the remix project's and therefore publicFolder will be wrong when resolved below, so I replaced it with process.cwd()

@itsMapleLeaf
Copy link
Owner

itsMapleLeaf commented Aug 30, 2024

@itsMapleLeaf thanks! If you add the formatter config on main I will rebase and format again, so it'll be easier to go through the changes.

It sounds like you're asking for the Prettier config? This project uses Biome, not Prettier, so you would need to install the Biome extension https://biomejs.dev/reference/vscode/

However, I'll update the github workflows so it auto-formats PRs as well, then this won't matter regardless of the local setup ¯\_(ツ)_/¯


It looks like this branch doesn't have the latest checks.yml version for some reason. It'll probably fix itself after you rebase it though

@itsMapleLeaf itsMapleLeaf force-pushed the esm branch 2 times, most recently from 41bd8f4 to ffbe05b Compare August 30, 2024 00:51
@giuseppeg
Copy link
Author

It sounds like you're asking for the Prettier config? This project uses Biome, not Prettier, so you would need to install the Biome extension https://biomejs.dev/reference/vscode/

Thanks for clarifying! The problem is that I don't use VSCode I guess. Not sure how to solve it, except for running pnpm format, which I did... perhaps the Biome has something like .prettierrc such that pnpm format will use that config?

@itsMapleLeaf
Copy link
Owner

itsMapleLeaf commented Aug 30, 2024

Biome's config is all in biome.json. The format script seems to work fine on my end, so uh... 😅 I'm not really sure! I'll try rebasing this again, but manually.

EDIT: So the formatter action works! But I think the issue here is that Biome doesn't support markdown yet 😢

I think I'm gonna switch back to Prettier until it does. Big miss on my part 😅

There are some new conflicts, they shouldn't be too difficult to address. I think I'll leave those up to you in case there's anything else you want to do here.

@itsMapleLeaf itsMapleLeaf force-pushed the esm branch 2 times, most recently from ffbe05b to 81802e5 Compare August 30, 2024 17:26
@giuseppeg
Copy link
Author

Thank you @itsMapleLeaf and sorry for being a bit slow to reply. I rebased and checks seem to be all green now.

@itsMapleLeaf itsMapleLeaf merged commit 1ba118a into itsMapleLeaf:main Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants