-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESM support #33
Add ESM support #33
Conversation
@itsMapleLeaf it would be great if you could add your formatter configuration to the repo such that formatting is consistent otherwise the script will probably use my personal config |
I'll take a closer look at this later, thanks for the PR! |
@itsMapleLeaf thanks! If you add the formatter config on |
}: InitRemixOptions): Promise<string> { | ||
const appRoot = app.getAppPath() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the electron app root not the remix project's and therefore publicFolder
will be wrong when resolved below, so I replaced it with process.cwd()
It sounds like you're asking for the Prettier config? This project uses Biome, not Prettier, so you would need to install the Biome extension https://biomejs.dev/reference/vscode/ However, I'll update the github workflows so it auto-formats PRs as well, then this won't matter regardless of the local setup ¯\_(ツ)_/¯ It looks like this branch doesn't have the latest |
41bd8f4
to
ffbe05b
Compare
Thanks for clarifying! The problem is that I don't use VSCode I guess. Not sure how to solve it, except for running |
Biome's config is all in EDIT: So the formatter action works! But I think the issue here is that Biome doesn't support markdown yet 😢 I think I'm gonna switch back to Prettier until it does. Big miss on my part 😅 There are some new conflicts, they shouldn't be too difficult to address. I think I'll leave those up to you in case there's anything else you want to do here. |
ffbe05b
to
81802e5
Compare
Thank you @itsMapleLeaf and sorry for being a bit slow to reply. I rebased and checks seem to be all green now. |
Add ESM support for the legacy compiler (no Vite).
Replaces #29